Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Lint with eslint, prettier, airbnb #52

Merged
merged 4 commits into from
May 15, 2018
Merged

Lint with eslint, prettier, airbnb #52

merged 4 commits into from
May 15, 2018

Conversation

eliperelman
Copy link
Member

No description provided.

edmorley
edmorley reviewed May 12, 2018
View reviewed changes
.travis.yml Outdated
@@ -2,14 +2,14 @@ dist: trusty
language: node_js
cache: yarn
node_js:
- '6.11.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might have to keep testing against node 6 for now, given the non-Neutrino consumers of webpack-chain (and that it would be good to release any new stringify features as a minor version if possible, to make it easier to compare Neutrino 8 and Neutrino 9 configs).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. I'll revert.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll drop Node.js 7 though.

@eliperelman eliperelman merged commit c31f4c6 into neutrinojs:master May 15, 2018
@eliperelman
Copy link
Member Author

Published in v4.7.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliperelman @edmorley