Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Switch noParse to getter/setter to allow webpack v3 function argument #32

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

eliperelman
Copy link
Member

@eliperelman eliperelman commented Aug 3, 2017

According to the Webpack release notes of v3, noParse supports being defined as a function. Because of this, we can no longer assume that noParse always contains a collection of RegExps, and instead this now has to become a shorthand getter/setter:

config.module.noParse(/something\.js/)

config.module.noParse([
  /a\.js/,
  /b\.js/,
  /c\.js/
])

config.module.noParse(content => /jquery|lodash/.test(content))

@eliperelman eliperelman merged commit c2f0aaa into neutrinojs:master Aug 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant