This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Switch noParse to getter/setter to allow webpack v3 function argument #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Webpack release notes of v3,
noParse
supports being defined as a function. Because of this, we can no longer assume that noParse always contains a collection ofRegExp
s, and instead this now has to become a shorthand getter/setter: