This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Adding noParse on module #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-sachs
force-pushed
the
noParse
branch
2 times, most recently
from
ef829fe to
760670f
Compare
|
Little bit confused by errors in codacy, given the changes are consistent with existing code base. |
eliperelman
approved these changes
May 18, 2017
src/Module.js
Outdated
| @@ -33,6 +36,9 @@ module.exports = class extends ChainedMap { | |||
| .keys(value) | |||
| .forEach(name => this.rule(name).merge(value[name])); | |||
| } | |||
| case 'noParse': { | |||
There was a problem hiding this comment.
Insert 1 blank line before this case.
|
@psachs21 don't worry about the codacy errors, I will get this merged. 😃 |
|
@eliperelman thanks! |
|
Released in v3.3.0! Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #26
Will need to update @types once changed.