This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Switch from Ava to Jest #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since: * Jest is used more elsewhere in the community, so people are likely more familiar with it * Ava seems to make more breaking changes (which has meant we've fallen behind the latest version as-is) - including dropping Node 8 in v3 * Jest has a few features that would be useful for us (eg snapshots) * I find the Jest docs easier to follow * Neutrino is likely to switch to Jest (since it has to have it in the list of deps anyway, for the `@neutrinojs/jest` preset) and it doesn't make sense to have projects under the `neutrinojs` org using differnet test runners (it's going to confuse me)
This was referenced Apr 12, 2020
eliperelman
approved these changes
Apr 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
@neutrinojs/jestpreset) and it doesn't make sense to have projects under theneutrinojsorg using different test runners (it's going to confuse me)Note: As part of this switch I've chosen not to enable jest-babel transformation of the ES Module usage in the test files (and instead converted them to CJS), since we can't use ESM in the webpack-chain source itself (unless we want a more complicated build/release process), and I think it's more consistent to just use CJS in all files until Node supports it natively (soon!).
The test assertion conversions were performed using the codemods here:
https://github.com/skovhus/jest-codemods
...other than a couple of issues in
test/Config.jsthe automated migration worked flawlessly! :-)