Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Update dependency prettier to v2 #250

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Update dependency prettier to v2 #250

merged 3 commits into from
Apr 12, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 24, 2020

This PR contains the following updates:

Package Type Update Change
prettier (source) devDependencies major ^1.19.1 -> ^2.0.0

Release Notes

prettier/prettier

v2.0.2

Compare Source

diff

2.0 regressions
JavaScript: Fix formatting of pseudo-elements and pseudo-classes in styled-components template literals (#​7842 by @​thorn0)
// Input
const Foo = styled.div`
  ${media.smallDown}::before {}
`;

// Prettier 2.0.0
const Foo = styled.div`
  ${media.smallDown}: : before{
  }
`;

// Prettier 2.0.2
const Foo = styled.div`
  ${media.smallDown}::before {
  }
`;
TypeScript: Avoid trailing commas on index signatures with only one parameter (#​7836 by @​bakkot)

TypeScript index signatures technically allow multiple parameters and trailing commas, but it's an error to have multiple parameters there, and Babel's TypeScript parser does not accept them. So Prettier now avoids putting a trailing comma there when you have only one parameter.

// Input
export type A = {
  a?: {
    [
      x: string
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

// Prettier 2.0.0
export type A = {
  a?: {
    [
      x: string,
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};

// Prettier 2.0.2
export type A = {
  a?: {
    [
      x: string
    ]: typeof SomeLongLongLongTypeName[keyof typeof SomeLongLongLongTypeName];
  } | null;
};
Revert "markdown: fix redundant leading spaces in markdown list" (#​7847)

See #​7846

Other changes
TypeScript: Fix prettier-ignore in union types (#​7798 by @​thorn0)
// Input
export type a =
  // foo
  | foo1&foo2
  // prettier-ignore
  | bar1&bar2
  // baz
  | baz1&baz2;

// Prettier 2.0.0
export type a =
  // foo
  | foo1&foo2
    // prettier-ignore
  // prettier-ignore
  | (bar1 & bar2)
  // baz
  | (baz1 & baz2);

// Prettier 2.0.2
export type a =
  // foo
  | (foo1 & foo2)
  // prettier-ignore
  | bar1&bar2
  // baz
  | (baz1 & baz2);

v2.0.1

Compare Source

diff

API: Fix build script to not corrupt import-fresh module (#​7820 by @​thorn0)

v2.0.0

Compare Source

diff

🔗 Release Notes


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@edmorley
Copy link
Member

Tests failing since they dropped support for Node 8.

edmorley added a commit that referenced this pull request Apr 10, 2020
Since it's EOL:
https://nodejs.org/en/about/releases/

...and supporting it is blocking changes like #250.

This is a breaking change so will need to be released in webpack-chain 7.
@edmorley edmorley mentioned this pull request Apr 10, 2020
@edmorley
Copy link
Member

Blocked on #255.

@renovate renovate bot force-pushed the renovate/prettier-2.x branch from c243355 to 8f018fe Compare April 12, 2020 10:43
Since Prettier has dropped support for Node 8, so yarn fails to install
without `--ignore-engines` and linting may not work.
@renovate
Copy link
Contributor Author

renovate bot commented Apr 12, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@edmorley
Copy link
Member

I've worked around Prettier dropping Node 8 support by adjusting the Travis matrix, such that linting does not run under Node 8, and that the yarn install also uses --ignore-engines.

This will allow us to upgrade now and put off dropping Node 8 for a bit longer, for the reasons in #255 (comment).

@edmorley edmorley merged commit dd229b5 into master Apr 12, 2020
@edmorley edmorley deleted the renovate/prettier-2.x branch April 12, 2020 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants