Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add devtoolNamespace TypeScript declaration #232

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

sirlancelot
Copy link
Contributor

@edmorley edmorley added the bug label Jan 28, 2020
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the PR :-)

Would you mind also adding devtoolNamespace to the docs here?
https://github.com/neutrinojs/webpack-chain#config-output-shorthand-methods

@edmorley
Copy link
Member

Also could you add a usage of devtoolNamespace to types/test/webpack-chain-tests.ts so that it's tested?

@edmorley edmorley added types and removed bug labels Jan 28, 2020
@sirlancelot
Copy link
Contributor Author

will do!

@sirlancelot
Copy link
Contributor Author

Updated & Rebased on to current master

@sirlancelot sirlancelot requested a review from edmorley January 28, 2020 20:01
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@edmorley edmorley merged commit fe6c6da into neutrinojs:master Jan 29, 2020
@edmorley edmorley added the docs label Jan 29, 2020
@edmorley
Copy link
Member

edmorley commented Feb 3, 2020

Released in v6.4.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants