This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Validate that Plugin 'args' is an array #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if `args` was set to something other than an array via any of `.use()`, `.tap()`, `.merge()` or `.set()`, that call would succeed but the later `.toConfig()` would fail with an unhelpful error message (when the `init` function tried to spread `args`). Now validation is performed at the time `args` is set, with a more helpful error message and stack trace. Fixes #121.
|
@neutrinojs/core-contributors (or anyone else), could I get a review? :-) |
|
Thank you :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if
argswas set to something other than an array via any of.use(),.tap(),.merge()or.set(), that call would succeed but the later.toConfig()would fail with an unhelpful error message (when theinitfunction tried to spreadargs).Now validation is performed at the time
argsis set, with a more helpful error message and stack trace.Fixes #121.