This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
add acho of chinese language #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@eliperelman what are your thoughts about this? It seems fine to me (only consideration perhaps whether to move the link down to the end of the introduction section etc) |
|
I think maybe put translated docs to the webpack-chain repo is better for maintenance in future? |
mc-zone
reviewed
Jan 19, 2019
README.md
Outdated
| @@ -17,6 +17,8 @@ This documentation corresponds to v5 of webpack-chain. For previous versions, se | |||
| _Note: while webpack-chain is utilized extensively in Neutrino, this package is | |||
| completely standalone and can be used by any project._ | |||
|
|
|||
| **[chinese docs（中文文档）](https://github.com/Yatoo2018/webpack-chain/tree/zh-cmn-Hans)** | |||
There was a problem hiding this comment.
a little wrong with the case:
- [chinese docs（中文文档）]
+ [Chinese docs (中文文档)]also using half-width brackets might better :)
Yeah I think this might be best. @Yatoo2018, would you mind updating the PR? :-) |
It 's OK. |
fix a little wrong
edmorley
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate the readme.md file to chinese