Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Commit

Permalink
Update config.mode type (#146)
Browse files Browse the repository at this point in the history
According to official documents of webpack, `config.mode` can be `none` in addition to `development` and `production`.

Refs: https://webpack.js.org/concepts/mode/
  • Loading branch information
imyelo authored and eliperelman committed Mar 7, 2019
1 parent d7851ea commit e2fcb61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ declare class Config extends __Config.ChainedMap<void> {
externals(value: webpack.ExternalsElement | webpack.ExternalsElement[]): this;
loader(value: any): this;
name(value: string): this;
mode(value: 'development' | 'production') : this;
mode(value: 'none' | 'development' | 'production') : this;
parallelism(value: number) : this;
profile(value: boolean): this;
recordsPath(value: string): this;
Expand Down
1 change: 1 addition & 0 deletions types/test/webpack-chain-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ config
.externals((context, request, cb) => cb(null, true))
.loader({})
.name("config-name")
.mode("none")
.mode("development")
.mode("production")
.profile(false)
Expand Down

0 comments on commit e2fcb61

Please sign in to comment.