This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
eslint: Lint the tests directory by default too #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
changed the title
|
I've updated the PR to remove the dotfiles addition, since it causes ...which would mean us having to override the airbnb rule here: ...which doesn't really make it worth doing for now. That rule is pretty annoying at times. |
The `tests` directory was already added to the `lint` script command by create-project, however it was not yet listed in the `include` for `eslint-loader`. The testing presets already update `envs` accordingly, to prevent errors from mocha/jest/... globals. The redundant `eslint.extensions` option has been removed, since that was only used by the ESLint Node API, which we no longer use. Fixes #331.
eliperelman
approved these changes
Jun 14, 2018
acconrad
pushed a commit
to acconrad/neutrino-dev
that referenced
this pull request
Jul 13, 2018
The `tests` directory was already added to the `lint` script command by create-project, however it was not yet listed in the `include` for `eslint-loader`. The testing presets already update `envs` accordingly, to prevent errors from mocha/jest/... globals. The redundant `eslint.extensions` option has been removed, since that was only used by the ESLint Node API, which we no longer use. Fixes neutrinojs#331.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testsdirectory was already added to thelintscript command by create-project, however it was not yet listed in theincludeforeslint-loader.The testing presets already update
envsaccordingly, to prevent errors from mocha/jest/... globals.The redundant
eslint.extensionsoption has been removed, since that was only used by the ESLint Node API, which we no longer use.Fixes #331.