-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] bump codecov version #908
Conversation
Reviewer's Guide by SourceryThis PR updates the CodeCov GitHub Action from version 4 to version 5 in the CI workflow. The change is straightforward and only involves a version bump in the workflow configuration file. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jdkent - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the PR description more completely, including the issue number if applicable and the motivation for upgrading codecov-action (e.g., new features, bug fixes, etc.).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -240,7 +240,7 @@ jobs: | |||
- name: Download artifacts | |||
uses: actions/download-artifact@v4 | |||
- name: Upload to CodeCov | |||
uses: codecov/codecov-action@v4 | |||
uses: codecov/codecov-action@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Consider pinning the codecov-action to a specific SHA instead of using a version tag
Using SHA pinning for GitHub Actions provides better security against supply chain attacks and ensures reproducible builds. You can find the SHA in the action's release page.
uses: codecov/codecov-action@v5 | |
uses: codecov/codecov-action@e0b68c0bf7215e3f6d54c0455fbd8a4201d259dd |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 48 48
Lines 6382 6382
=======================================
Hits 5631 5631
Misses 751 751 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Closes # .
Changes proposed in this pull request:
Summary by Sourcery
CI: