Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] bump codecov version #908

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Nov 16, 2024

Closes # .

Changes proposed in this pull request:

Summary by Sourcery

CI:

  • Update Codecov GitHub Action from version 4 to version 5 in the CI workflow.

Copy link
Contributor

sourcery-ai bot commented Nov 16, 2024

Reviewer's Guide by Sourcery

This PR updates the CodeCov GitHub Action from version 4 to version 5 in the CI workflow. The change is straightforward and only involves a version bump in the workflow configuration file.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update CodeCov GitHub Action version
  • Bump codecov-action from v4 to v5
  • Maintain existing configuration for fail_ci_if_error and environment variables
.github/workflows/testing.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jdkent - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the PR description more completely, including the issue number if applicable and the motivation for upgrading codecov-action (e.g., new features, bug fixes, etc.).
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -240,7 +240,7 @@ jobs:
- name: Download artifacts
uses: actions/download-artifact@v4
- name: Upload to CodeCov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider pinning the codecov-action to a specific SHA instead of using a version tag

Using SHA pinning for GitHub Actions provides better security against supply chain attacks and ensures reproducible builds. You can find the SHA in the action's release page.

Suggested change
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@e0b68c0bf7215e3f6d54c0455fbd8a4201d259dd

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (52400d3) to head (2f81609).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #908   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          48       48           
  Lines        6382     6382           
=======================================
  Hits         5631     5631           
  Misses        751      751           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jdkent jdkent merged commit 4511404 into neurostuff:main Nov 18, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant