Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inherit IBMAEstimator's aggressive_mask from previous Datasets #652

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Feb 27, 2022

Closes #651.

Changes proposed in this pull request:

  • Remove the aggressive_mask key at the beginning of MetaEstimator._preprocess_inputs() if it's defined. Basically, this redefines aggressive_mask from scratch any time fit is called.
  • Mask data with the aggressive mask only if that aggressive mask is defined.
    • At first glance, this should be a bug that's come up already, and yet it hasn't. I assume there's a reason why CBMAEstimators loading ma_maps haven't failed due to a missing aggressive_mask key in inputs_, but I don't know what it is at the moment.

@tsalo tsalo added bug Issues noting problems and PRs fixing those problems. ibma Issues/PRs pertaining to image-based meta-analysis labels Feb 27, 2022
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #652 (86b5878) into main (8f166ab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   84.88%   84.89%   +0.01%     
==========================================
  Files          40       40              
  Lines        4386     4389       +3     
==========================================
+ Hits         3723     3726       +3     
  Misses        663      663              
Impacted Files Coverage Δ
nimare/base.py 88.54% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f166ab...86b5878. Read the comment docs.

@tsalo tsalo merged commit 02387b9 into neurostuff:main Feb 28, 2022
@tsalo tsalo deleted the fix-aggressive-mask branch February 28, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems. ibma Issues/PRs pertaining to image-based meta-analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBMA aggressive masks are inherited across fits, causing opaque errors
1 participant