-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FocusCounter diagnostic tool #649
Conversation
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 84.88% 85.01% +0.12%
==========================================
Files 40 40
Lines 4386 4457 +71
==========================================
+ Hits 3723 3789 +66
- Misses 663 668 +5
Continue to review full report at Codecov.
|
Currently failing because Jackknife has issues with the IBMA estimator, which I'm guessing is due to changes in the aggressive mask based on the subset of experiments in the meta-analysis. |
The problem is that, when you fit the same IBMA estimator multiple times, each time the aggressive mask is updated based on the new data and the existing aggressive mask using a logical or, meaning that good voxels in an older dataset will be retained when fitting to the new dataset. This causes problems when some of those older voxels are not good for the new dataset. This problem wasn't already apparent because all of our Jackknife tests on IBMAs had good data in all of the voxels, I believe. Or at least the aggressive mask didn't change from one subset of studies to another. I'm not sure what the best solution is. Here are some ideas:
|
For the sake of this PR, I will probably just make a copy, since that's probably a good idea in general. I will also open a separate issue about the aggressive mask bug. |
Closes #595.
Changes proposed in this pull request:
nimare.diagnostics
,FocusCounter
, that characterizes CBMA results based on the number of foci in each experiment within the Dataset that contributed to each cluster.FocusCounter
tables in the Sleuth ALE workflow (ref Improve ALE workflow outputs #594).fit
s, causing opaque errors #651 specifically forJackknife
diagnostic by operating on a copy of the Estimator within the study loop.