Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Rename kernel_estimator attribute to kernel_transformer #197

Merged
merged 1 commit into from
May 14, 2020

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 7, 2019

Closes None. References #195. Pending #163.

Changes proposed in this pull request:

  • Change CBMAEstimators' kernel_estimator attribute to kernel_transformer.

@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #197   +/-   ##
======================================
  Coverage    53.2%   53.2%           
======================================
  Files          71      71           
  Lines        4368    4368           
======================================
  Hits         2324    2324           
  Misses       2044    2044
Impacted Files Coverage Δ
nimare/parcellate/mamp.py 0% <0%> (ø) ⬆️
nimare/meta/cbma/ale.py 93.06% <84.61%> (ø) ⬆️
nimare/meta/cbma/mkda.py 90.55% <85%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569d54d...754cade. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented May 14, 2020

@tyarkoni I know that the plan was to wait until #163 was merged, but I imagine that the PyMARE integration will actually take a while. Do you mind if I merge this now? I doubt it will cause major conflicts for your branch.

@tyarkoni
Copy link
Contributor

Go for it!

@tsalo tsalo merged commit bc3aad0 into neurostuff:master May 14, 2020
@tsalo tsalo deleted the ref/kernel_transformer branch May 14, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants