[Fix] eda_plot throws ValueError when the number of onsets is not the same as the number of peaks #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where you had an exception if there was not the same number of peaks and onsets. This can happen on signal that has been cut (ex: depending on difference conditions). The fix just ignores the first peak (only for display) when there is no onset for the first peak.
|
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
|
Salut @mperreir, thanks a lot for the contribution! Tests are failing because of something else, so I'll merge this :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where you had an exception if there was not the same number of peaks and onsets (issue #632). This can happen on signal that has been cut (ex: depending on difference conditions).
Proposed Changes
The fix just ignores the first peak (only for display) when there is no onset for the first peak.
Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)