[Fix] ECG delineate order #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cg_delineate_order
…cg_delineate_order
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #815 +/- ##
==========================================
+ Coverage 53.82% 53.88% +0.06%
==========================================
Files 295 295
Lines 13799 13800 +1
==========================================
+ Hits 7427 7436 +9
+ Misses 6372 6364 -8
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@Tam-Pham could you throw a quick look at this to make sure we didn't overlook something basic? |
|
@Tam-Pham bump |
1 similar comment
|
@Tam-Pham bump |
|
Let's merge that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue of incorrect ordering in the
ecg_delineate()output. See #761Proposed Changes
I changed the
_dwt_delineate_qrs_bounds()function so only R_Onsets before the Q_Peaks are selected.Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)