Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Webcam video processing for remote physiology (rPPG, ...) (EXPLORATORY) #736

Merged
merged 16 commits into from
Nov 1, 2022

Conversation

DominiqueMakowski
Copy link
Member

@DominiqueMakowski DominiqueMakowski commented Oct 20, 2022

Perhaps for 2.3

video_plot()

Can now easily plots some frames alongside physio signal(s); will be useful for debugging and validating

image

@DominiqueMakowski DominiqueMakowski changed the title [Test] Webcam video processing for remote physiology [Feature] Webcam video processing for remote physiology (rPPG, ...) Oct 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 53.32% // Head: 53.10% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (b734ccb) compared to base (ac1f757).
Patch coverage: 13.80% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #736      +/-   ##
==========================================
- Coverage   53.32%   53.10%   -0.22%     
==========================================
  Files         284      290       +6     
  Lines       12869    12964      +95     
==========================================
+ Hits         6862     6885      +23     
- Misses       6007     6079      +72     
Impacted Files Coverage Δ
neurokit2/ppg/ppg_report.py 100.00% <ø> (ø)
neurokit2/signal/signal_interpolate.py 64.44% <ø> (ø)
neurokit2/signal/signal_rate.py 100.00% <ø> (ø)
neurokit2/data/read_bitalino.py 15.09% <4.76%> (+6.25%) ⬆️
neurokit2/video/video_skin.py 5.00% <5.00%> (ø)
neurokit2/video/video_plot.py 11.90% <11.90%> (ø)
neurokit2/misc/progress_bar.py 14.28% <14.28%> (ø)
neurokit2/video/video_ppg.py 16.66% <16.66%> (ø)
neurokit2/video/video_face.py 17.24% <17.24%> (ø)
neurokit2/data/read_video.py 16.66% <50.00%> (+4.16%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DominiqueMakowski
Copy link
Member Author

Verdict: it doesn't work 😢

https://github.com/DominiqueMakowski/RemotePhysiology

@DominiqueMakowski
Copy link
Member Author

DominiqueMakowski commented Nov 1, 2022

I think I'll merge this, as it doesn't add too much maintenance burden. I marked all the functions docstrings as highly exploratory + added the link to the test and mentioned that rPPG probably doesn't work as of yet.

Hopefully, it will serve as a basis for future improvements!

@DominiqueMakowski DominiqueMakowski changed the title [Feature] Webcam video processing for remote physiology (rPPG, ...) [Feature] Webcam video processing for remote physiology (rPPG, ...) (EXPLORATORY) Nov 1, 2022
@DominiqueMakowski DominiqueMakowski merged commit d37ca7a into dev Nov 1, 2022
@DominiqueMakowski DominiqueMakowski deleted the feature_video_init branch November 1, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants