-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] ECG delineator peak index #731
[Fix] ECG delineator peak index #731
Conversation
Code Climate has analyzed commit 8331d3c and detected 0 issues on this pull request. View more on Code Climate. |
Also should we add https://github.com/neuropsychology/NeuroKit/files/9758396/debug.csv to https://github.com/neuropsychology/NeuroKit/tree/master/tests/ecg_data & use the code that led to the error as a test for Pip install: https://gist.github.com/danibene/8b5df2192b5a063d10e59972d77556d6 but maybe it'd be good to have it as a proper test? |
Codecov ReportBase: 53.33% // Head: 53.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #731 +/- ##
==========================================
- Coverage 53.33% 53.32% -0.01%
==========================================
Files 283 283
Lines 12844 12845 +1
==========================================
Hits 6850 6850
- Misses 5994 5995 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, thanks for digging into the delineator code, it's a tough one :)
Description
This PR aims to fix an error in
ecg_delineate()
where invalid indices were returned. See also #729Proposed Changes
I changed the
ecg_delineate()
function so that within_ecg_delineator_peak()
, all indices of fiducial points are checked to ensure that they are not larger than the number of samples in the ECG signal - 1Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)