[Fix] Fixed failing complexity test #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the delay I just came back from vacations and it's pretty busy! |
|
|
|
No worries, I am grateful for all the work that you do for this project and did not expect to get answers right away. I don't have that much experience with testing. There are a couple of other things I want to do first (like adding more RVT measures), but I can look into the test suite afterwards if I have time. Generally, I think it already is good if there is an automated test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because misc/expspace.py was changed in this commit, the adjacent test now fails. As also proposed in #683 , I now also want to just adjust the numbers to what I get in a notebook. Also I linted the whole file.
If there are other (py)tests failing, I also want to clean that up over the weekend.
Proposed Changes
The interesting changes are on line 40 and 42 with new exact numbers. The rest is just linting; I also changed from a print message to an exception in line 634.
Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)