-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for pdb and python wheel compatibility #584
Conversation
- internal readline was built with neuron wheel - as internal readline is very old, it cause issue with readline library present on target machine. - now build newer readline 7.0 with ncurses included and link that with neuron - also update dockerfile used for wheel building - update ci scripts and pipeline to publish wheel as artifacts for testing
@nrnhines : can you check if the issue of pdb incompatibility also exist on OSX? |
CI is failing with below error:
So when external readline library is used, that library is being added to nrnivmodl command. When wheel is being installed target machine, obviously that readline path doesn't exist. We need to exclude readline from nrnivmodl if it's static. |
@nrnhines : can you try installing wheel from here and see if you still see segfault with pdb? https://dev.azure.com/neuronsimulator/nrn/_build/results?buildId=532&view=artifacts&type=publishedArtifacts You have to login to azure and have to click |
I installed on my mac and it now works correctly. |
Reviewing this change, it seems that it will make sense at some point in the future to eliminate nrn/src/readline and use this strategy along with a cmake replacement option for NRN_ENABLE_INTERNAL_READLINE to better reflect the process. Please ping me if this pull request is ready to squash and merge with the master. |
@nrnhines : could you try also on Ubuntu 18 where it was failing with the test case of pdb? if that works then it's ready to merge! |
python 3.6.10 works for ubuntu 18.4 |
Ok, I will build new wheel. |
with readline library present on target machine.
and link that with neuron
artifacts for testing