Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize DECREF (part 2). #3205

Merged
merged 12 commits into from
Nov 15, 2024
Merged

Modernize DECREF (part 2). #3205

merged 12 commits into from
Nov 15, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 14, 2024

Another batch of refactoring to remove DECREF.

Copy link

sonarcloud bot commented Nov 14, 2024

Copy link

✔️ 4911707 -> Azure artifacts URL

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (c18450a) to head (4911707).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 85.18% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3205   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         569      569           
  Lines      111206   111196   -10     
=======================================
- Hits        74592    74590    -2     
+ Misses      36614    36606    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review November 14, 2024 10:00
@1uc 1uc changed the title Modernize DECREF. Modernize DECREF (part 2). Nov 14, 2024
@1uc 1uc merged commit cdd3fae into master Nov 15, 2024
34 checks passed
@1uc 1uc deleted the 1uc/modernize-decref-2 branch November 15, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants