Fix for certain modelDB CI failures #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ e93caaa -> Azure artifacts URL |
JCGoran
force-pushed
the
jelic/workaround_hoc_pow
branch
from
e93caaa
to
ea049c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3194 +/- ##
=======================================
Coverage 67.06% 67.07%
=======================================
Files 570 569 -1
Lines 111232 111206 -26
=======================================
- Hits 74600 74592 -8
+ Misses 36632 36614 -18 ☔ View full report in Codecov by Sentry. |
|
✔️ ea049c1 -> Azure artifacts URL |
This reverts commit bea2ceb.
|
✔️ bea2ceb -> Azure artifacts URL |
JCGoran
changed the title
|
|
✔️ 3e7434c -> Azure artifacts URL |
nrnhines
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, #3135 introduced a level of indirection to
std::pow, which seems to be problematic for some models (model IDs:149100 3800 113997 144520 126467 256388), in particular, when using the-O2optimization flag (see #3137 (comment), #3137 (comment), #3137 (comment)).The solution is to include
nrnconf.h, and put the entire NOCMODL change under an#ifguard, sincenrnconf.hhas a#define NRN_ENABLE_ARCH_INDEP_EXP_POW [0/1], and the#ifguard appears later, so it works in either case.The azure URL of the successful run (I disabled all CI to build it faster): #3194 (comment)
The modelDB run: https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/11782044837/job/32816199196
Note that I am using #3163 as the baseline (this azure URL: #3163 (comment)) due to #3093, which causes some other models to fail due to fact that 8.2.6 doesn't use
TABLEforhh.mod, while currentmasterdoes, but this does not have an impact on the models mentioned above.