Add setuptools to install_requires #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing a pre-built wheel in a venv on Python 3.12, calling `nrniv` fails because the wrapper script uses `setuptools` for some functionality, so it should also be added as a runtime dependency.
heerener
approved these changes
Feb 9, 2024
|
|
✔️ 0fe22c2 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2720 +/- ##
=======================================
Coverage 66.23% 66.24%
=======================================
Files 559 559
Lines 104008 104008
=======================================
+ Hits 68890 68898 +8
+ Misses 35118 35110 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a pre-built wheel in a venv on Python 3.12+, calling
nrnivfails because the wrapper script usessetuptoolsfor some functionality (and it's not added to the venv anymore as of Python 3.12+, see python/cpython#95299), so it should also be added as a runtime dependency of NEURON.NOTE: this should also be backported to 8.2 if we want full Python 3.12 compatibility.