nonlinz.cpp: use eigen instead of sparse13

[alkino]

• diag_ have been removed. Those was pointer for direct access to the diagonal elements, but Eigen can relocate matrix and invalidate pointers.
• double* rv_ (real v_) and double* jv_ (imag v_), have been changed to std::vector<double> v_.
• char* m_ (the sparse13 matrix) have been changed to a Eigen::SparseMatrix<std::complex<double>> m_. The solver Eigen::SparseLU lu_ have been added. One of the main difference is that sparse13 is 1-indexed and Eigen: 0-indexed.
• The whole complex version of sparse13 have been removed because this was the last use.
• transfer_amp, input_amp, transfer_phase, input_phase and ratio_amp have all been simplified by using standard functions of std::complex instead of computing by ourself.
• v_index have been removed because this was a vector i -> i + 1. Now that Eigen is 0-indexed it becomes really useless.
• In the file partrans.cpp the function pargag_jacob_rhs has been modified to support std::complex<double>, so know we do only one call of the function (before one with real and one with complex part), but inside we loop twice on real and complex because the algorithm is hard to understand to do everything in once.

[azure-pipelines]

✔️ f71b138 -> Azure artifacts URL

[azure-pipelines]

✔️ ba6cb29 -> Azure artifacts URL

[azure-pipelines]

✔️ 62b1507 -> Azure artifacts URL

[azure-pipelines]

✔️ 01a2dfc -> Azure artifacts URL

[azure-pipelines]

✔️ 12b8d64 -> Azure artifacts URL

[codecov]

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (45cdea7) 66.18% compared to head (5f3bf6d) 66.19%.

Files	Patch %	Lines
src/nrniv/nonlinz.cpp	55.84%	34 Missing ⚠️
src/nrniv/partrans.cpp	96.29%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2623   +/-   ##
=======================================
  Coverage   66.18%   66.19%           
=======================================
  Files         559      559           
  Lines      108940   108880   -60     
=======================================
- Hits        72107    72070   -37     
+ Misses      36833    36810   -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azure-pipelines]

✔️ beaacfa -> Azure artifacts URL

[github-actions]

NEURON ModelDB CI: launching for beaacfa via its drop url

[azure-pipelines]

✔️ 5130833 -> Azure artifacts URL

[github-actions]

NEURON ModelDB CI: launching for a8f33b3 via its drop url

[iomaganaris]

LGTM in general and has reasonable changes. Some small suggestions only. I must say that I'm not familiar with sparse13 and Eigen though. For the validity of the changes I would refer to the modeldbci

[azure-pipelines]

✔️ bc5c51c -> Azure artifacts URL

[ohm314]

Overall really good changes, but I do have a few questions and requests :)

[azure-pipelines]

✔️ 27af30a -> Azure artifacts URL

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ 5f3bf6d -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #185850 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[ohm314]

looks good!