Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve: NodeList.include_flux #2588

Merged
merged 13 commits into from
Oct 28, 2023
Merged

Resolve: NodeList.include_flux #2588

merged 13 commits into from
Oct 28, 2023

Conversation

rgourdine
Copy link
Collaborator

closes #1644

@rgourdine rgourdine added the rxd reaction-diffusion label Oct 20, 2023
@rgourdine rgourdine self-assigned this Oct 20, 2023
@azure-pipelines
Copy link

✔️ e5b4d87 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ 9f32be8 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Merging #2588 (492a8a1) into master (3bbdd8d) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2588      +/-   ##
==========================================
- Coverage   66.07%   66.07%   -0.01%     
==========================================
  Files         559      559              
  Lines      108910   108910              
==========================================
- Hits        71965    71962       -3     
- Misses      36945    36948       +3
Files Coverage Δ
share/lib/python/neuron/rxd/nodelist.py 68.33% <100.00%> (+1.66%) ⬆️
share/lib/python/neuron/rxd/node.py 81.96% <80.00%> (+0.51%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ 07c32b6 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ a0b3d2b -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 096d139 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ ecf70fc -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ b2ebbb9 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@ramcdougal ramcdougal enabled auto-merge (squash) October 27, 2023 01:48
@azure-pipelines
Copy link

✔️ 585676d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@azure-pipelines
Copy link

✔️ 492a8a1 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #165358 (:white_check_mark:) have been uploaded here!

Status and direct links:

@ramcdougal ramcdougal merged commit ca5730e into master Oct 28, 2023
34 of 35 checks passed
@ramcdougal ramcdougal deleted the node_flux branch October 28, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees

@rgourdine rgourdine

Labels
rxd reaction-diffusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeList.include_flux doesn't work with constant fluxes
4 participants
@rgourdine @bbpbuildbot @ramcdougal @adamjhn