Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SETUPTOOLS_USE_DISTUTILS=stdlib #1924

Merged
merged 3 commits into from
Jul 19, 2022
Merged

SETUPTOOLS_USE_DISTUTILS=stdlib #1924

merged 3 commits into from
Jul 19, 2022

Conversation

alexsavulescu
Copy link
Member

Closes #1605 #1921

Still in need to tackle distutils deprecation though.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #1924 (55b7263) into master (f505247) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   47.24%   47.20%   -0.04%     
==========================================
  Files         543      543              
  Lines      112941   112941              
==========================================
- Hits        53354    53309      -45     
- Misses      59587    59632      +45     
Impacted Files Coverage Δ
src/nrnmpi/bbsmpipack.cpp 81.95% <0.00%> (-10.25%) ⬇️
src/parallel/bbsclimpi.cpp 50.57% <0.00%> (-8.63%) ⬇️
src/parallel/bbssrvmpi.cpp 41.46% <0.00%> (-6.10%) ⬇️
src/parallel/bbs.cpp 74.57% <0.00%> (-1.70%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@azure-pipelines
Copy link

✔️ d6c92b7 -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 2544fa8 -> Azure artifacts URL

Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@azure-pipelines
Copy link

✔️ 55b7263 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit 962533e into master Jul 19, 2022
@alexsavulescu alexsavulescu deleted the stp branch July 19, 2022 09:17
nrnhines pushed a commit that referenced this pull request Nov 9, 2022
nrnhines added a commit that referenced this pull request Nov 9, 2022
* SETUPTOOLS_USE_DISTUTILS=stdlib (#1924)

* Workaround for: #1605 See:
   * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html
   * https://setuptools.pypa.io/en/latest/history.html#id228

Co-authored-by: Olli Lupton <[email protected]>
cherry-pick from master 962533e to allow build with Python3.11

* check for NULL. (already fixed in master 962533e)

* Add python3.11 to pkg build. Some hints for the build script.

Co-authored-by: Alexandru Săvulescu <[email protected]>
@alexsavulescu alexsavulescu mentioned this pull request Nov 9, 2022
3 tasks
pramodk added a commit that referenced this pull request Nov 23, 2022
 * removal of distutils.log.Log from setuptools breaks
   building packages like numpy. See pypa/setuptools#3693
 * we have used SETUPTOOLS_USE_DISTUTILS alternative already in #1924
 * update circle-ci and azure pipelines similarly
pramodk added a commit that referenced this pull request Nov 23, 2022
* removal of distutils.log.Log from setuptools breaks
   building packages like numpy. See pypa/setuptools#3693
 * we have used SETUPTOOLS_USE_DISTUTILS alternative already in #1924
 * update circle-ci and azure pipelines similarly
alexsavulescu added a commit that referenced this pull request Dec 15, 2022
* SETUPTOOLS_USE_DISTUTILS=stdlib (#1924)

* Workaround for: #1605 See:
   * https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html
   * https://setuptools.pypa.io/en/latest/history.html#id228

Co-authored-by: Olli Lupton <[email protected]>
cherry-pick from master 962533e to allow build with Python3.11

* check for NULL. (already fixed in master 962533e)

* Add python3.11 to pkg build. Some hints for the build script.

Co-authored-by: Alexandru Săvulescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants