Disallow STATE variables being GLOBAL #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* state variables can not be global, see #1479 (comment) * before code generation iterate through all symbols and error if there is any state variable declared as global.
olupton
approved these changes
Mar 23, 2022
|
Yes, it will give error like: cai is as a STATE variable and hence cannot be declared as GLOBAL at line 130 in file /..../some-dir/test.mod
^ |
Fix typo
nrnhines
approved these changes
Mar 23, 2022
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1723 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 551 551
Lines 111206 111213 +7
=======================================
+ Hits 50380 50386 +6
- Misses 60826 60827 +1 ☔ View full report in Codecov by Sentry. |
pramodk
added a commit
to ModelDBRepository/2487
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/2730
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/64296
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/2733
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/64229
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/93321
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/116094
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/149739
that referenced
this pull request
May 23, 2022
pramodk
added a commit
to ModelDBRepository/232097
that referenced
this pull request
May 23, 2022
ramcdougal
pushed a commit
to ModelDBRepository/2487
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/2730
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/2733
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/64229
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/64296
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/93321
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/116094
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/149739
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
ramcdougal
pushed a commit
to ModelDBRepository/232097
that referenced
this pull request
May 27, 2022
…nrn/pull/1723 (#1) * Avoid declaring (ion) state variables as global, see neuronsimulator/nrn/pull/1723 * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UndefinedBehaviourSanitizer fixes #1479 (comment)
symbols and error if there is any state variable
declared as global.