Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exec wrapper on hclass2/3 modules #1095

Closed
wants to merge 4 commits into from

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Mar 20, 2021

Closes #1092

@codecov-io
Copy link

Codecov Report

Merging #1095 (3d996e5) into master (42a5c3c) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 3d996e5 differs from pull request most recent head 046fab4. Consider uploading reports for the commit 046fab4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   30.67%   30.66%   -0.01%     
==========================================
  Files         571      571              
  Lines      108743   108784      +41     
==========================================
+ Hits        33357    33361       +4     
- Misses      75386    75423      +37     
Impacted Files Coverage Δ
share/lib/python/neuron/hclass2.py 0.00% <ø> (ø)
share/lib/python/neuron/hclass3.py 22.72% <ø> (-77.28%) ⬇️
share/lib/python/neuron/__init__.py 25.60% <66.66%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a5c3c...046fab4. Read the comment docs.

@Helveg
Copy link
Contributor Author

Helveg commented Mar 20, 2021

Closed in favor of #1096

@Helveg Helveg closed this Mar 20, 2021
@Helveg Helveg deleted the hclass-simple branch April 16, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hclass2.py and hclass3.py are exec strings
2 participants