-
Notifications
You must be signed in to change notification settings - Fork 118
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numprocs=x
print
#1255
Comments
Without understanding technical details of the problem, I would say this printf message has been quite useful for users to find out simple mistakes in job scripts where things are running with wrong number of processes or serially (agree that I am trying to be About the Printf technicalities, I will let Michael to comment here. |
I'd like to leave it in for nrniv. But for python, I've moved to the side of quieter is better. It may be that people will become familiar with
|
Is there a global or something that knows if we're running from Python? Also, does running via |
nrniv generates a banner unless launched with There is a global that knows if python is launched and extended with NEURON vs nrniv is launched and embedded python called My feeling is that |
How about this? We make it so it prints the The relevant change would be confined to Line 163 in 078f125
|
I like that. The problem is that when nrniv is launched the code in nrnmpi.cpp is executed before ivoc_main(...) where the args are read. Turns out it is easier (I think) to just not print if python was launched by interrogating |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Overview of the feature
NEURON under MPI prints an initial
numprocs=n
that can not be turned off and can not be silenced by capturingstdout
from Python. It usesprintf
but is called at a point in time wherePrintf
is not available yet. Remedying all these things would require considerable efforts. I propose to simply remove the print.Issues with the amount of MPI processes can be diagnosed in alternative ways:
h.ParallelContext().nhost()
mpi4py
Foreseeable Impact
People wouldn't accidentally stumble upon an error with their number of MPI processes when they accidentally fumble and make an error with their number of MPI processes.
The text was updated successfully, but these errors were encountered: