Skip to content

Commit

Permalink
curate 136803 & update PR CI selection of models (#52)
Browse files Browse the repository at this point in the history
* curate 136803
   * model_dir: mod_files
* update PR selection of models
* add description of model selection for PRs
  • Loading branch information
alexsavulescu authored Sep 13, 2022
1 parent c9e6163 commit b3bda58
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
15 changes: 13 additions & 2 deletions .github/workflows/nrn-modeldb-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,19 @@ jobs:

- name: Set models to run for PR
run: |
# Select a few models to run CI for PRs
echo 'MODELS_TO_RUN=279 3264 22203 144549 105507 194897' >> $GITHUB_ENV
# For PRs we only have a few models for quick sanity checking.
# Once the PR is green you need to manually run the ModelDB CI workflow by simply selecting your branch in the UI.
# The follwing selection aims to target different features (since we haven't worked on unit testing yet -> #38 ).
# Select a few models to run CI for PRs:
# 64195 -> run: null
# 22203 -> skip: true
# 156120 -> several model directories
# 97868 -> failed nrnivmodl
# 146030 -> curate_patterns
# 244679 -> no entry in modeldb-run.yaml
# rest: -> currently yielding differences in the pipeline
echo 'MODELS_TO_RUN=64195 22203 156120 51781 97868 22203 97756 97917 105507 136803 138379 138382 146030 244679 251881' >> $GITHUB_ENV
if: github.event_name == 'pull_request'

- name: Install dependencies and project
Expand Down
5 changes: 5 additions & 0 deletions modeldb/modeldb-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,11 @@
- verify_graph_()
script:
- sed -i'.bak' -e 's/tstop = 550/tstop = 100/' HAM_SR1.ses
136803:
run:
- run()
- verify_graph_()
model_dir: mod_files
# python models
189922:
python: true
Expand Down

0 comments on commit b3bda58

Please sign in to comment.