Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI weekly on main #92

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Run CI weekly on main #92

merged 3 commits into from
Nov 10, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Nov 10, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like to run our tests regularly, because we rarely make changes to the repo, so we are unlikely to catch dependencies going out of date.

What does this PR do?

Adds a GH workflow that triggers the test workflow weekly on Sunday at 3AM only on this repo (not on its forks) and on the main branch.

References

Closes #55

How has this PR been tested?

Unfortunately, newly created scheduled runs are triggered only on the default branch (for security reasons), so this is difficult to test. I suggest to merge this today and check on Monday whether it was successful?

The changes are based on the nightly build of libsbml (where I know it "works").

An earlier attempt #91 at triggering the test workflow from a different workflow was

  • started because I thought this solution would be more complicated than it turned out.
  • abandoned because it didn't work out of the box and felt even more complicated in the end.

Why should this not run on other forks?

  • feels like a waste of energy in case there will be many forks in the future (presumably all ~synced to this one)
  • it doesn't feel right to cause extra CI runs on other people's repos when they fork/sync their fork

Is this a breaking change?

No.

Does this PR require an update to the documentation?

Added a sentence to the README of the CI subfolder.

Checklist:

  • [⚠️ ] The code has been tested locally ⚠️ No, explicitly not ⚠️
  • [NA] Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review November 10, 2023 09:11
@alessandrofelder alessandrofelder requested a review from a team November 10, 2023 09:11
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge and we'll find out if it indeed does what we want.

@niksirbi niksirbi merged commit 588cddb into main Nov 10, 2023
12 checks passed
@niksirbi niksirbi deleted the weekly-scheduled-test-clean branch November 10, 2023 09:19
@alessandrofelder
Copy link
Member Author

Confirming this works as expected 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a config to test repos weekly
2 participants