[TUI] Add validation to create folders #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
force-pushed
the
tui-dev-branch
branch
from
ce6c6c7 to
c8369aa
Compare
JoeZiminski
force-pushed
the
add_validation_to_create_folders
branch
13 times, most recently
from
d16bf05 to
79d89a7
Compare
JoeZiminski
changed the base branch from
tui-dev-branch
to
add_name_templates_and_improve_validation
JoeZiminski
force-pushed
the
add_validation_to_create_folders
branch
from
79d89a7 to
ae40cdc
Compare
|
TODO: for some reason the right-click autofill is not working on macos. |
b-peri
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Hey Joe, thanks a lot for this very extensive (and very cool) PR! I've added a few additional commits to clean up some redundant code in the .tcss files and template_settings.py, but otherwise this seems great as is!
One note: As you likely already noticed yourself, create_folders.py is starting to get a bit bloated (and hard to read!), so I think we'll need to come back and refactor out some of the auxiliary logic down the line (esp. things like validators). We can meet to discuss this once #265 is done and dusted if that works?
Merged
JoeZiminski
force-pushed
the
add_name_templates_and_improve_validation
branch
from
e1d0058 to
fb7440a
Compare
…in project config folder.
…lected in `datatype_dict`.
JoeZiminski
force-pushed
the
add_validation_to_create_folders
branch
from
960a6bb to
79a8917
Compare
JoeZiminski
changed the base branch from
add_name_templates_and_improve_validation
to
tui-dev-branch
JoeZiminski
added a commit
that referenced
this pull request
Jan 12, 2024
* Add validation to subject and session Inputs. * Load datatype checkbox status from a persistent settings file stored in project config folder. * Introduce CreateFolderSettings page to manage the template names. * Format and give functionality to the template settings page. * Add hyperlink, small tidy ups. * Tidy up css and add light-mode for new widgets. * Refactoring and tidy ups on TUI modules. * Handle nonetype templates properly. * Small refactorings and tidy-ups. * Align + tidy up CreateFoldersTab button widgets * Minor cleanups `tui_menu.tcss` * Update project selector menubar to allow vertical scroll bar. * Update datatype dict on mount so that any persistent settings are reflected in `datatype_dict`. * Some more minor cleanup --------- Co-authored-by: b-peri <[email protected]>
JoeZiminski
added a commit
that referenced
this pull request
Feb 1, 2024
* Add validation to subject and session Inputs. * Load datatype checkbox status from a persistent settings file stored in project config folder. * Introduce CreateFolderSettings page to manage the template names. * Format and give functionality to the template settings page. * Add hyperlink, small tidy ups. * Tidy up css and add light-mode for new widgets. * Refactoring and tidy ups on TUI modules. * Handle nonetype templates properly. * Small refactorings and tidy-ups. * Align + tidy up CreateFoldersTab button widgets * Minor cleanups `tui_menu.tcss` * Update project selector menubar to allow vertical scroll bar. * Update datatype dict on mount so that any persistent settings are reflected in `datatype_dict`. * Some more minor cleanup --------- Co-authored-by: b-peri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes improvement to the 'Create' tab on the project manager screen that is used to create folders. It adds:
sub-.As part of the above two general features atr introduced:
require_double_click. This will run the function it decorates if a double-click signal is detected, otherwise nothing will happen (the logic is the same as previous implementation only generalised).There are no tests except for manual testing. There is no TUI documentation at the moment.