fix(string-formatter): fixed string formatter dependencies

neuroglia-io · Nov 29, 2023 · 946d633 · 946d633
1 parent 0730e59
commit 946d633
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/.github/js-packages.json b/.github/js-packages.json
@@ -7,7 +7,9 @@
   "string-formatter": {
     "name": "@neuroglia/string-formatter",
     "path": "./",
-    "dependencies": []
+    "dependencies": [
+      "@neuroglia/common"
+    ]
   },
   "logging": {
     "name": "@neuroglia/logging",

diff --git a/.github/workflows/js-main.yml b/.github/workflows/js-main.yml
@@ -65,8 +65,10 @@ jobs:
 
   pipeline:
     needs: changes
+    continue-on-error: true
     strategy:
       max-parallel: 1
+      fail-fast: false
       matrix:
         package: ${{ fromJSON(needs.changes.outputs.packages) }}
     uses: ./.github/workflows/js-package-pipeline.yml

diff --git a/projects/neuroglia/string-formatter/package.json b/projects/neuroglia/string-formatter/package.json
@@ -22,6 +22,10 @@
     "url": "https://github.com/neuroglia-io/js-framework/issues"
   },
   "homepage": "https://neuroglia.io",
+  "peerDependencies": {
+    "@neuroglia/common": "*",
+    "date-fns": "^2.18.0"
+  },
   "dependencies": {
     "tslib": "^2.0.0"
   }

diff --git a/projects/neuroglia/string-formatter/src/lib/string-formatter.ts b/projects/neuroglia/string-formatter/src/lib/string-formatter.ts
@@ -1,4 +1,4 @@
-import { get, isObject } from '@neuroglia/common';
+import { get } from '@neuroglia/common';
 
 /**
  * Formats the provided message with the provided array of parameters