Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker/login-action from 2.1.0 to 2.2.0 #651

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump docker/login-action from 2.1.0 to 2.2.0 #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e1ac0
Bump docker/login-action from 2.1.0 to 2.2.0
dependabot[bot] Jun 8, 2023
cdd0520
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Install dependencies
run: make setup
- name: Login to ghcr.io
uses: docker/login-action@v2.1.0
uses: docker/login-action@v2.2.0
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Install dependencies
run: make setup
- name: Login to ghcr.io
uses: docker/login-action@v2.1.0
uses: docker/login-action@v2.2.0
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
18 changes: 10 additions & 8 deletions tests/unit/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,21 +652,23 @@ async def test_get_latest_value_unknown_instance_type(
self,
collector_factory: Callable[..., AbstractContextManager[GCPNodePriceCollector]],
) -> None:
with collector_factory("n1-highmem-8", "unknown", True) as collector:
with pytest.raises(AssertionError, match=r"Found prices only for: \[\]"):
await collector.get_latest_value()
with collector_factory(
"n1-highmem-8", "unknown", True
) as collector, pytest.raises(
AssertionError, match=r"Found prices only for: \[\]"
):
await collector.get_latest_value()

async def test_get_latest_value_unknown_gpu(
self,
collector_factory: Callable[..., AbstractContextManager[GCPNodePriceCollector]],
) -> None:
with collector_factory(
"n1-highmem-8-1xv100", "n1-highmem-8", True
) as collector:
with pytest.raises(
AssertionError, match=r"Found prices only for: \[CPU, RAM\]"
):
await collector.get_latest_value()
) as collector, pytest.raises(
AssertionError, match=r"Found prices only for: \[CPU, RAM\]"
):
await collector.get_latest_value()


class TestAzureNodePriceCollector:
Expand Down