Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix neuro cli version #133

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix neuro cli version #133

merged 2 commits into from
Nov 20, 2020

Conversation

anayden
Copy link
Contributor

@anayden anayden commented Nov 20, 2020

No description provided.

YevheniiSemendiak
YevheniiSemendiak approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Thank you!

@asvetlov
Copy link
Contributor

Ideally, we want to auto-update the pinned version number and publish a new image on every neuromation release.
The publishing requires manual steps (bumping the version number at least) but the dependency checker can make a PR automatically as Dependabot does.
@romasku already implemented something similar for platform-pipelines.
You can borrow the idea from here: https://github.com/neuro-inc/platform-pipelines/blob/master/.github/workflows/update-images.yml

@anayden anayden merged commit 689d5fb into master Nov 20, 2020
@anayden anayden deleted the an/fix-neuro-cli-version branch November 20, 2020 13:14
@anayden anayden mentioned this pull request Nov 23, 2020
Open
@YevheniiSemendiak YevheniiSemendiak mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YevheniiSemendiak YevheniiSemendiak YevheniiSemendiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anayden @asvetlov @YevheniiSemendiak