Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --resume keyword and recipe loading #33

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Fix --resume keyword and recipe loading #33

merged 2 commits into from
Apr 14, 2022

Conversation

KSGulin
Copy link

@KSGulin KSGulin commented Apr 13, 2022

Fix for:

  • Runs that are continued with the --resume keyword
  • Previously uncaught cases of recipe loading

@KSGulin KSGulin requested review from a team, mgoin, bfineran and InquestGeronimo and removed request for a team April 13, 2022 17:51
@KSGulin KSGulin self-assigned this Apr 13, 2022
mgoin
mgoin approved these changes Apr 13, 2022
View reviewed changes
export.py
Comment on lines +503 to +505
train_recipe = ckpt.get('recipe')
elif recipe or ckpt.get('recipe'):
train_recipe, checkpoint_recipe = recipe, ckpt.get('recipe')
Copy link
Member

@mgoin mgoin Apr 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, didn't know about get() defaulting to None

@KSGulin KSGulin merged commit 2aae700 into master Apr 14, 2022
KSGulin added a commit that referenced this pull request Apr 14, 2022
@KSGulin
Fix --resume keyword and recipe loading (#33)
9e55207
KSGulin added a commit that referenced this pull request Apr 15, 2022
@KSGulin
Catch up main -> release/0.12 (#35)
c2fe8bd 
* pip installable auto package

* Adjust NMS time limit warning to batch size (ultralytics#7156)

* NMS unused variable fix (ultralytics#7161)

* Fix --resume keyword and recipe loading (#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarques anmarques anmarques approved these changes

@mgoin mgoin mgoin approved these changes

@bfineran bfineran Awaiting requested review from bfineran bfineran was automatically assigned from neuralmagic/machine-learning

@InquestGeronimo InquestGeronimo Awaiting requested review from InquestGeronimo InquestGeronimo was automatically assigned from neuralmagic/machine-learning

Assignees

@KSGulin KSGulin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KSGulin @mgoin @anmarques