Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

add some guards for pypi push #327

Merged
merged 4 commits into from
Jun 23, 2024
Merged

add some guards for pypi push #327

merged 4 commits into from
Jun 23, 2024

Conversation

dhuangnm
Copy link
Member

  1. Added an input argument push_binaries_to_pypi to allow not pushing to nm pypi automatically. It's 'yes' for nightly and 'no' for release by default.

  2. Require all tests to pass before uploading.

@robertgshaw2-redhat
Copy link
Collaborator

@dhuangnm looks like this broke remote push workflow

Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this broke remote-push workflow

@dhuangnm
Copy link
Member Author

this broke remote-push workflow

Just fixed the issue.

Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertgshaw2-redhat
Copy link
Collaborator

Lm eval failure is spurious (marlin) - score is > baseline. Merging

@robertgshaw2-redhat robertgshaw2-redhat merged commit 9b2e107 into main Jun 23, 2024
36 of 37 checks passed
@robertgshaw2-redhat robertgshaw2-redhat deleted the fixpush branch June 23, 2024 22:22
derekk-nm pushed a commit that referenced this pull request Jun 24, 2024
1. Added an input argument push_binaries_to_pypi to allow not pushing to
nm pypi automatically. It's 'yes' for nightly and 'no' for release by
default.

2. Require all tests to pass before uploading.

---------

Co-authored-by: dhuangnm <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants