Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible global leak #12

Closed
jmdobry opened this issue Apr 12, 2014 · 2 comments
Closed

Possible global leak #12

jmdobry opened this issue Apr 12, 2014 · 2 comments

Comments

@jmdobry
Copy link

jmdobry commented Apr 12, 2014

previousKeys and keyServer appear to be leaking globally, at least, that's what Mocha claims.
screen shot 2014-04-12 at 2 43 57 pm

https://github.com/neumino/rethinkdbdash/blob/master/lib/term.js#L950

https://github.com/neumino/rethinkdbdash/blob/master/lib/term.js#L1022
@neumino
Copy link
Owner

neumino commented Apr 12, 2014

Thanks, I'll fix that with #13

@neumino
Copy link
Owner

neumino commented Apr 12, 2014

It's fixed in master, I'll push it as soon as I'm done with #13.

neumino added a commit that referenced this issue Apr 12, 2014
@neumino
Fix leak -- Fix #12
3309d8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmdobry @neumino