feat: handle ipfs messages #47
Conversation
| } else if (type === "ipfs") { | ||
| let { url, gateway, timeout: timeoutFromMsg } = message.options; | ||
|
|
||
| const nativeIPFSPattern = /^(ipfs:\/\/)([^/?#]+)(.*)/; |
There was a problem hiding this comment.
I believe this regex could be part of the schema package or not?
There was a problem hiding this comment.
This can be part of the schema package but we will need it here too. Because we are using it to split the IPFS message into protocol, hash and CID.
There was a problem hiding this comment.
potentiall we could also use a fork if is-ipfs that spits out the CID
This commit also removes @neume-network/message-schema because it has been deprecated. Fixes #33
As we have deprecated message-schema package. The `workerMessage` object is now exported from the schema package.
The CI will still not pass because we need to merge neume-network/schema#40 first.
|
@TimDaub The unit tests will pass after neume-network/schema#40 has been merged. I have tested the PR locally using npm link and the tests do pass. We can also see in the latest logs that only the tests related to IPFS fail because they can't validate the message. Worth noting that the |
|
we need to update package-lock.json to have the unit tests pass |
|
@TimDaub Tests are still failing. I am checking the reason right now. |
This change was prompted by an update in neume-network/schema.
|
@TimDaub This PR is now ready to be merged. Just needed to change |
|
awesome thanks |
This PR adds the ability to handle IPFS messages which are defined in neume-network/schema#40.
The extraction-worker accepts native IPFS URLs like
ipfs://<cid>and it will be the responsibility of the strategy to format the request as a native URL. For eg. soundxyz will format pinata URLs. This will also ensure that all the IPFS URLs in music-os are native.Currently we are not running our own IPFS node therefore a gateway is required in each message.
The extraction-worker also validates CID before sending a request. This will prevent us from sending unnecessary requests and purge bad IPFS URLs. In future, we can also do #45.
This PR also removes @neume-network/message-schema package as that has been deprecated.
Note: In order for tests to pass in GitHub actions we need to merge neume-network/schema#40. Locally all the tests pass.