[TASK] Added some magento-mirror versions and changed LokeyCoding to OpenMage #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenMage (which is the official fork now)
|
I have a similar one in the lineup (feature/magento-mirror) it's also taking care of the missing sample-data. I think it's otherwise close to yours. I just wait until the next build gets green, so please don't fix the build here yet. |
|
@fbrnc I just updated the develop branch. can you rebase your PR branch and check if you've got further changes? You might see many conflicts, they should be the same change on both sides, if not, this might signal a wrong change at someones end. |
|
@fbrnc I'll review, too. Just FYI. |
|
@fbrnc: I could resolve it. I'll merge and put it into develop. I hope it's green then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #724