Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

second contribution #38

Merged
merged 6 commits into from
Apr 4, 2022
Merged

second contribution #38

merged 6 commits into from
Apr 4, 2022

Conversation

deepthi1107
Copy link
Contributor

No description provided.

@deepthi1107
Copy link
Contributor Author

@MridulS, review my PR.

MridulS
MridulS reviewed Apr 3, 2022
View reviewed changes
2022-round-1/deepthi1107/nx_tutorial_script.py
graph1.add_node(11)
graph1.add_node("N1")
L=[1,2,3]
graph1.add_nodes_from(L)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepthi1107!

Could you also add a tuple object as a node. Currently there are only int and str type objects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, @MridulS.

@deepthi1107
Copy link
Contributor Author

Hello @MridulS, I have made changes.

@MridulS
Copy link
Member

MridulS commented Apr 4, 2022

Thanks @deepthi1107!

@MridulS MridulS merged commit 4cbd893 into networkx:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MridulS MridulS MridulS left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi1107 @MridulS