Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate IMMUTABLE flag on socket protocol (driver=>upsd); use it in netset; sanity-check if (defaulted) NUMBER values are not in fact STRINGs #2549

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Propagate IMMUTABLE flag on socket protocol (driver=>upsd); use it in netset; sanity-check if (defaulted) NUMBER values are not in fact STRINGs #2549

wants to merge 12 commits into from
+122 −2

Commits on Jul 23, 2024

  1. server/netget.c, docs/net-protocol.txt: set_var(): report IMMUTABLE f… 

    …lag on values in DEBUG builds [networkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ad253f2 View commit details
    Browse the repository at this point in the history

  2. server/netset.c: consider IMMUTABLE flag to reject setting a value [n… 

    …etworkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5b6f193 View commit details
    Browse the repository at this point in the history

  3. server/netget.c: sanity-check NUMBER values that they actually resolv… 

    …e as float or long int [networkupstools#266]

If we assume a value without flags is by default a NUMBER but is not,
re-default it to STRING. If it is also flagged explicitly as a NUMBER
but is not, yell a warning for upstream to fix the code. Eventually
this should be a reason to report protocol error, but not now.

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    56a9063 View commit details
    Browse the repository at this point in the history

  4. NEWS.adoc, UPGRADING.adoc: document changes of handling for IMMUTABLE… 

    …, STRING and NUMBER flags [networkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f73ef06 View commit details
    Browse the repository at this point in the history

  5. drivers/dstate.c, common/state.c: allow to dump and receive "IMMUTABL… 

    …E" flag value [networkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1820cfa View commit details
    Browse the repository at this point in the history

  6. server/netget.c: get_type(): use str_to_*_strict() methods instead of… 

    … reinventing the wheel [networkupstools#266, networkupstools#966]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5776fb2 View commit details
    Browse the repository at this point in the history

  7. server/netget.c: get_type(): simplify logging and vars used [networku… 

    …pstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7fb4afe View commit details
    Browse the repository at this point in the history

  8. NEWS.adoc, UPGRADING.adoc: clarify that PR networkupstools#266 adds I… 

    …MMUTABLE flag propagation on socket protocol (and fix float=>double)

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a90432d View commit details
    Browse the repository at this point in the history

  9. docs/sock-protocol.txt: update with propagation of IMMUTABLE flag [ne… 

    …tworkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a47ceb5 View commit details
    Browse the repository at this point in the history

  10. server/netget.c: do not actually report a STRING:N value so far [netw… 

    …orkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3e5d04e View commit details
    Browse the repository at this point in the history

  11. server/netget.c: get_type(): reword logged messages [networkupstools#266 

    ]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    38a675c View commit details
    Browse the repository at this point in the history

  12. server/netget.c: fix use of "#if DEBUG" when it is not defined [netwo… 

    …rkupstools#266]

Signed-off-by: Jim Klimov <[email protected]>
    @jimklimov
    jimklimov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7e7e70b View commit details
    Browse the repository at this point in the history