Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use str* API in place of isdigit() in server/conf.c #676

Open
clepple opened this issue Mar 13, 2019 · 1 comment · May be fixed by #677
Open

use str* API in place of isdigit() in server/conf.c #676

clepple opened this issue Mar 13, 2019 · 1 comment · May be fixed by #677
Assignees
@aquette
Labels
C-str Issues and PRs about C/C++ methods, headers and data types dealing with strings and memory blocks refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Milestone
2.8.4

Comments

@clepple
Copy link
Member

clepple commented Mar 13, 2019

isdigit() takes a char/int, not a char*.

Originally mentioned here, but we need to fix this before the next release.
@clepple clepple added this to the 2.7.5 milestone Mar 13, 2019
@aquette aquette self-assigned this Mar 13, 2019
aquette added a commit to aquette/nut that referenced this issue Mar 13, 2019
@aquette
Use str* API to check for valid numeric value
dd6cdbe 
Closes networkupstools#676

Signed-off-by: Arnaud Quette <[email protected]>
@aquette aquette linked a pull request Mar 13, 2019 that will close this issue
Open
@aquette aquette added the ready / code review Author (and CI) consider the PR worthy of human rewievers' time label Mar 13, 2019
jimklimov added a commit to jimklimov/nut that referenced this issue Apr 5, 2019
@jimklimov
Problem: isdigit() receives a char* instead of char
f366621 
Solution: as a quick fix, pick the first char of the string we pass.
The proper fix would be to use the str_*() API for safe conversions,
in a later iteration.

See-also: networkupstools#676

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Apr 5, 2019
@jimklimov
Problem: isdigit() receives a char* instead of char
d13b5b4 
Solution: as a quick fix, pick the first char of the string we pass.
The proper fix would be to use the str_*() API for safe conversions,
in a later iteration.

See-also: networkupstools#676

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Apr 5, 2019
@jimklimov
Problem: isdigit() receives a char* instead of char
04da795 
Solution: as a quick fix, pick the first char of the string we pass.
The proper fix would be to use the str_*() API for safe conversions,
in a later iteration.

See-also: networkupstools#676

Signed-off-by: Jim Klimov <[email protected]>
@jimklimov jimklimov mentioned this issue Apr 5, 2019
Merged
aquette pushed a commit that referenced this issue Apr 5, 2019
@jimklimov @aquette
Problem: isdigit() receives a char* instead of char (#690)
159ea07 
Solution: as a quick fix, pick the first char of the string we pass.
The proper fix would be to use the str_*() API for safe conversions,
in a later iteration.

See-also: #676

Signed-off-by: Jim Klimov <[email protected]>
@clepple clepple removed the ready / code review Author (and CI) consider the PR worthy of human rewievers' time label Apr 29, 2019
@clepple clepple changed the title fix invocation of isdigit(), or use str* API use str* API in place of isdigit() in server/conf.c Apr 29, 2019
@clepple clepple modified the milestones: 2.7.5, 2.7.6 Apr 29, 2019
@clepple
Copy link
Member Author

clepple commented Apr 29, 2019

I'm bumping the milestone from 2.7.5 to 2.7.6 because we merged #690, which fixes the misuse of isdigit(). I still think that a slightly reworked version of #677 (with signed/unsigned expanded out into separate variables, etc.) should be merged into the following release.

@biergaizi biergaizi mentioned this issue Jan 25, 2021
Open
@jimklimov jimklimov added the refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings label Nov 14, 2021
@jimklimov jimklimov mentioned this issue Aug 19, 2022
Open
@jimklimov jimklimov modified the milestones: 2.8.1, 2.8.2 Jan 6, 2023
@jimklimov jimklimov modified the milestones: 2.8.2, 2.8.3 Apr 4, 2024
@jimklimov jimklimov added the C-str Issues and PRs about C/C++ methods, headers and data types dealing with strings and memory blocks label Apr 10, 2024
@jimklimov jimklimov modified the milestones: 2.8.3, 2.8.4 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aquette aquette

Labels
C-str Issues and PRs about C/C++ methods, headers and data types dealing with strings and memory blocks refactor/fightwarn PR or issue proposal to improve code maintainability without functional changes, or to fix warnings
Projects
None yet
Milestone
2.8.4
Development

Successfully merging a pull request may close this issue.

Use str* API to check for valid numeric value aquette/nut
3 participants
@clepple @aquette @jimklimov