Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ABC, deprecate and remove show_list and config_list methods, add fact properties #275

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Remove ABC, deprecate and remove show_list and config_list methods, add fact properties #275

merged 4 commits into from
Apr 5, 2023

Conversation

jeffkala
Copy link
Contributor

@jeffkala jeffkala commented Apr 5, 2023

This implements most of #183 , closes #96 , removes all config_list and show_list methods completely (hence a major version bump is needed.

@jeffkala
Copy link
Contributor Author

jeffkala commented Apr 5, 2023

@jmcgill298 think this should cover some of the long outstanding issues, would love a review if you get a chance.

@jmcgill298
Copy link
Contributor

looks good @jeffkala

@jeffkala jeffkala merged commit 5ca3906 into develop Apr 5, 2023
@jeffkala jeffkala deleted the jkala-depr-list_methods branch April 5, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pszulczewski pszulczewski Awaiting requested review from pszulczewski pszulczewski is a code owner

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ABCs
2 participants
@jeffkala @jmcgill298