-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize etherchannel, lacp, and portchannel capture groups #1585
Merged
jvanderaa
merged 16 commits into
networktocode:master
from
mjbear:normalize_portchannel
Feb 22, 2024
Merged
Normalize etherchannel, lacp, and portchannel capture groups #1585
jvanderaa
merged 16 commits into
networktocode:master
from
mjbear:normalize_portchannel
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
January 7, 2024 03:51
(aligns with ios/asa and arista_eos) -- adjust BUNDLE_STATUS -- adjust BUNDLE_PROTOCOL_STATE -- adjust MEMBER_INTERFACE_STATUS
mjbear
force-pushed
the
normalize_portchannel
branch
from
February 21, 2024 02:20
0b50e2a
to
63e795d
Compare
rebased against NTC master branch to bring the git history up to current |
jvanderaa
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Breaking Change --
This was done to make life easier when working with structured data from multiple vendors. Predictable capture group names for common items equals less "hacky code" to handle the structured data. (Trying to keep it
DRY
.)