Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize etherchannel, lacp, and portchannel capture groups #1585

Merged
merged 16 commits into from
Feb 22, 2024

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Jan 7, 2024

-- Breaking Change --

This was done to make life easier when working with structured data from multiple vendors. Predictable capture group names for common items equals less "hacky code" to handle the structured data. (Trying to keep it DRY.)

  • Normalize a number of capture group names for common data across the etherchannel, lacp, and portchannel templates (asa, ios, nxos, arista_eos)
  • Normalize some cisco_nxos portchannel capture group regex to remove extra "captured" parentheses which became part of the structured data
    • (removing parentheses from being captured matches ios, asa, and arista_eos templates)

@mjbear
Copy link
Contributor Author

mjbear commented Feb 21, 2024

rebased against NTC master branch to bring the git history up to current

@jvanderaa jvanderaa merged commit 876120c into networktocode:master Feb 22, 2024
14 checks passed
@mjbear mjbear deleted the normalize_portchannel branch June 22, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants