Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdiff module #269

Merged
merged 5 commits into from
Apr 12, 2023
Merged

jdiff module #269

merged 5 commits into from
Apr 12, 2023

Conversation

pszulczewski
Copy link
Contributor

Depends on #268

chadell
chadell reviewed Oct 7, 2022
View reviewed changes
plugins/action/jdiff.py Outdated Show resolved Hide resolved
chadell
chadell reviewed Oct 7, 2022
View reviewed changes
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
chadell
chadell reviewed Oct 7, 2022
View reviewed changes
plugins/action/jdiff.py Outdated Show resolved Hide resolved
chadell
chadell reviewed Oct 7, 2022
View reviewed changes
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
chadell
chadell reviewed Oct 7, 2022
View reviewed changes
plugins/action/jdiff.py Outdated Show resolved Hide resolved
pszulczewski
pszulczewski commented Oct 10, 2022
View reviewed changes
plugins/action/jdiff.py Show resolved Hide resolved
plugins/modules/jdiff.py Show resolved Hide resolved
plugins/modules/jdiff.py Show resolved Hide resolved
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
plugins/modules/jdiff.py Show resolved Hide resolved
pszulczewski
pszulczewski commented Oct 10, 2022
View reviewed changes
plugins/action/jdiff.py Outdated Show resolved Hide resolved
@jeffkala
Copy link
Collaborator

Now that #268 is implemented @pszulczewski can you get this out of draft and ready to go? Needs to be 1.1.0 release, and need to add the added_in_version stuff to 1.1.0

@pszulczewski pszulczewski marked this pull request as ready for review April 11, 2023 08:32
jeffkala
jeffkala requested changes Apr 11, 2023
View reviewed changes
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
plugins/modules/jdiff.py Outdated Show resolved Hide resolved
@jeffkala jeffkala merged commit 2ea1741 into networktocode:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadell chadell chadell left review comments

@jeffkala jeffkala jeffkala approved these changes

@jvanderaa jvanderaa jvanderaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pszulczewski @jeffkala @chadell @jvanderaa