Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/netflix #258

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Feature/netflix #258

merged 4 commits into from
Dec 28, 2023

Conversation

jmaslak
Copy link
Contributor

@jmaslak jmaslak commented Dec 26, 2023

Add Netflix parser for AS2906 connections

data["circuits"].append(CircuitImpact(circuit_id=line.lstrip(), impact=impact))
maintenance_id += line + "/"

data["end"] = data["start"] + hours * 3660 + minutes * 60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 3660 instead of 3600? (60 minutes of 60 seconds)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an error. I will fix!

Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit 91fee6a into networktocode:develop Dec 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants