Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client chain element to monitor dead NSEs #1581

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NikitaSkrynnik
Copy link
Contributor

Description

Added a new client chain element that monitors NSE it has a connection to. If it get deleted:true event from the registry for this NSE it calls Close to close the client side of the connection to the NSE.

Original goal is to close leaked connections from vl3 NSEs to dead vl3 NSEs in the vl3 Network (because vl3 network doesn't have healing.

Issue link

networkservicemesh/cmd-nse-vl3-vpp#289

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@90f0c79). Click here to learn what that means.

❗ Current head 2be5d6c differs from pull request most recent head bb2a5e3. Consider uploading reports for the commit bb2a5e3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage        ?   67.25%           
=======================================
  Files           ?      261           
  Lines           ?    12382           
  Branches        ?        0           
=======================================
  Hits            ?     8327           
  Misses          ?     3530           
  Partials        ?      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nikita Skrynnik <[email protected]>
Signed-off-by: Nikita Skrynnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants