Handle NS and NSE server wait timeouts cleanly #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC server-side streaming calls should be closed by returning nil so we need to figure out what the timeout Error looks like and return nil when it happens so we don't get logs full of spurious errors. Signed-off-by: Toby Cabot <[email protected]>
ghost
|
I found a cleaner way to do this (in the watch()) function). |
glazychev-art
approved these changes
Nov 10, 2022
denis-tingaikin
approved these changes
Nov 15, 2022
denis-tingaikin
approved these changes
Nov 15, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Nov 15, 2022
…k-k8s@main PR link: networkservicemesh/sdk-k8s#394 Commit: 08c7453 Author: Denis Tingaikin Date: 2022-11-15 03:38:02 +0300 Message: - Merge pull request #394 from acnodal/clean-timeouts Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC server-side streaming calls should be closed by returning nil so we need to figure out what the timeout Error looks like and return nil when it happens. In this case the Error has an "unknown" code so we use the error message. When it happens we return nil and the server-side streaming call is closed cleanly.
Signed-off-by: Toby Cabot [email protected]