Feature/calico integration #4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <[email protected]>
Mixaster995
force-pushed
the
feature/calico-integration
branch
from
05384ea to
e2dfaaa
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
Mixaster995
force-pushed
the
feature/calico-integration
branch
from
e2dfaaa to
354f532
Compare
denis-tingaikin
requested changes
Dec 22, 2021
examples/basic/README.md
Outdated
| @@ -31,7 +31,11 @@ kubectl create ns nsm-system | |||
| 2. Apply NSM resources for basic tests: | |||
|
|
|||
| ```bash | |||
| kubectl apply -k https://github.com/networkservicemesh/deployments-k8s/examples/basic?ref=bbe46ecf104280e96ae3a32d4757149e792f0d11 | |||
| if [[ "${CALICO}" == "on" ]]; then | |||
There was a problem hiding this comment.
Please don't use env. As I can see we can simply create a separate suite(setup) for calico and add links at supported use-cases.
There was a problem hiding this comment.
@denis-tingaikin ok, refactored example structure, please, take a look
Mixaster995
force-pushed
the
feature/calico-integration
branch
5 times, most recently
from
753366d to
0a3335b
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
Mixaster995
force-pushed
the
feature/calico-integration
branch
from
0a3335b to
42109f6
Compare
|
@denis-tingaikin refactored folder structure - please, take a look |
denis-tingaikin
approved these changes
Dec 23, 2021
nsmbot
pushed a commit
to networkservicemesh/integration-tests
that referenced
this pull request
Dec 23, 2021
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#4143 Commit: 7dc61bf Author: Network Service Mesh Bot Date: 2021-12-23 04:55:22 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added calico patches
Issue
part of networkservicemesh/integration-k8s-kind#325